Explorar o código

Clean up tests to remove redundant fail() assertions

Sam Jaffe %!s(int64=6) %!d(string=hai) anos
pai
achega
8918372681

+ 1 - 6
src/test/java/org/leumasjaffe/json/schema/tester/EqualsTesterTest.java

@@ -1,7 +1,6 @@
 package org.leumasjaffe.json.schema.tester;
 
 import static org.junit.Assert.assertThat;
-import static org.junit.Assert.fail;
 import static org.leumasjaffe.json.schema.matcher.Accepts.accepts;
 import static org.leumasjaffe.json.schema.matcher.JsonPath.jsonPath;
 import static org.leumasjaffe.json.schema.matcher.Not.not;
@@ -49,11 +48,7 @@ public class EqualsTesterTest {
 	
 	@Test
 	public void testValidateDoesNothingOnSuccess() {
-		try {
-			constTest.validate(new DoubleNode(1.0));
-		} catch (ValidationException ve) {
-			fail("An exception occured: " + ve.getMessage());
-		}
+		constTest.validate(new DoubleNode(1.0));
 	}
 	
 	@Test(expected=ValidationException.class)

+ 1 - 6
src/test/java/org/leumasjaffe/json/schema/tester/FormatTesterTest.java

@@ -1,7 +1,6 @@
 package org.leumasjaffe.json.schema.tester;
 
 import static org.junit.Assert.assertThat;
-import static org.junit.Assert.fail;
 import static org.leumasjaffe.json.schema.matcher.Accepts.accepts;
 import static org.leumasjaffe.json.schema.matcher.JsonPath.jsonPath;
 import static org.leumasjaffe.json.schema.matcher.AcceptedTypes.acceptsTypes;
@@ -148,11 +147,7 @@ public class FormatTesterTest {
 	
 	@Test
 	public void testValidateDoesNothingOnSuccess() {
-		try {
-			FormatTester.forCode("ipv6").validate(new TextNode("::1"));
-		} catch (ValidationException ve) {
-			fail("An exception occured: " + ve.getMessage());
-		}
+		FormatTester.forCode("ipv6").validate(new TextNode("::1"));
 	}
 	
 	@Test(expected=ValidationException.class)

+ 1 - 6
src/test/java/org/leumasjaffe/json/schema/tester/NumberTesterTest.java

@@ -1,7 +1,6 @@
 package org.leumasjaffe.json.schema.tester;
 
 import static org.junit.Assert.assertThat;
-import static org.junit.Assert.fail;
 import static org.leumasjaffe.json.schema.matcher.AcceptedTypes.acceptsTypes;
 import static org.leumasjaffe.json.schema.matcher.Accepts.accepts;
 import static org.leumasjaffe.json.schema.matcher.JsonPath.jsonPath;
@@ -87,11 +86,7 @@ public class NumberTesterTest {
 	
 	@Test
 	public void testValidateDoesNothingOnSuccess() {
-		try {
-			NumberTester.multipleOf(1.0).validate(new DoubleNode(2.0));
-		} catch (ValidationException ve) {
-			fail("An exception occured: " + ve.getMessage());
-		}
+		NumberTester.multipleOf(1.0).validate(new DoubleNode(2.0));
 	}
 	
 	@Test(expected=ValidationException.class)

+ 1 - 6
src/test/java/org/leumasjaffe/json/schema/tester/TypeTesterTest.java

@@ -1,7 +1,6 @@
 package org.leumasjaffe.json.schema.tester;
 
 import static org.junit.Assert.assertThat;
-import static org.junit.Assert.fail;
 import static org.leumasjaffe.json.schema.matcher.Accepts.accepts;
 import static org.leumasjaffe.json.schema.matcher.JsonPath.jsonPath;
 import static org.leumasjaffe.json.schema.matcher.AcceptedTypes.acceptsTypes;
@@ -132,11 +131,7 @@ public class TypeTesterTest {
 	
 	@Test
 	public void testValidateDoesNothingOnSuccess() {
-		try {
-			TypeTester.fromType("number").validate(new DoubleNode(2.0));
-		} catch (ValidationException ve) {
-			fail("An exception occured: " + ve.getMessage());
-		}
+		TypeTester.fromType("number").validate(new DoubleNode(2.0));
 	}
 	
 	@Test(expected=ValidationException.class)