inline.py 25 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615
  1. # Known Bugs when inlining a function/method
  2. # The values passed to function are inlined using _inlined_variable.
  3. # This may cause two problems, illustrated in the examples below
  4. #
  5. # def foo(var1):
  6. # var1 = var1*10
  7. # return var1
  8. #
  9. # If a call to foo(20) is inlined, the result of inlined function is 20,
  10. # but it should be 200.
  11. #
  12. # def foo(var1):
  13. # var2 = var1*10
  14. # return var2
  15. #
  16. # 2- If a call to foo(10+10) is inlined the result of inlined function is 110
  17. # but it should be 200.
  18. import re
  19. import rope.base.exceptions
  20. import rope.refactor.functionutils
  21. from rope.base import (pynames, pyobjects, codeanalyze,
  22. taskhandle, evaluate, worder, utils)
  23. from rope.base.change import ChangeSet, ChangeContents
  24. from rope.refactor import (occurrences, rename, sourceutils,
  25. importutils, move, change_signature)
  26. def unique_prefix():
  27. n = 0
  28. while True:
  29. yield "__" + str(n) + "__"
  30. n += 1
  31. def create_inline(project, resource, offset):
  32. """Create a refactoring object for inlining
  33. Based on `resource` and `offset` it returns an instance of
  34. `InlineMethod`, `InlineVariable` or `InlineParameter`.
  35. """
  36. pycore = project.pycore
  37. pyname = _get_pyname(pycore, resource, offset)
  38. message = 'Inline refactoring should be performed on ' \
  39. 'a method, local variable or parameter.'
  40. if pyname is None:
  41. raise rope.base.exceptions.RefactoringError(message)
  42. if isinstance(pyname, pynames.ImportedName):
  43. pyname = pyname._get_imported_pyname()
  44. if isinstance(pyname, pynames.AssignedName):
  45. return InlineVariable(project, resource, offset)
  46. if isinstance(pyname, pynames.ParameterName):
  47. return InlineParameter(project, resource, offset)
  48. if isinstance(pyname.get_object(), pyobjects.PyFunction):
  49. return InlineMethod(project, resource, offset)
  50. else:
  51. raise rope.base.exceptions.RefactoringError(message)
  52. class _Inliner(object):
  53. def __init__(self, project, resource, offset):
  54. self.project = project
  55. self.pycore = project.pycore
  56. self.pyname = _get_pyname(self.pycore, resource, offset)
  57. range_finder = worder.Worder(resource.read())
  58. self.region = range_finder.get_primary_range(offset)
  59. self.name = range_finder.get_word_at(offset)
  60. self.offset = offset
  61. self.original = resource
  62. def get_changes(self, *args, **kwds):
  63. pass
  64. def get_kind(self):
  65. """Return either 'variable', 'method' or 'parameter'"""
  66. class InlineMethod(_Inliner):
  67. def __init__(self, *args, **kwds):
  68. super(InlineMethod, self).__init__(*args, **kwds)
  69. self.pyfunction = self.pyname.get_object()
  70. self.pymodule = self.pyfunction.get_module()
  71. self.resource = self.pyfunction.get_module().get_resource()
  72. self.occurrence_finder = occurrences.create_finder(
  73. self.pycore, self.name, self.pyname)
  74. self.normal_generator = _DefinitionGenerator(self.project,
  75. self.pyfunction)
  76. self._init_imports()
  77. def _init_imports(self):
  78. body = sourceutils.get_body(self.pyfunction)
  79. body, imports = move.moving_code_with_imports(
  80. self.pycore, self.resource, body)
  81. self.imports = imports
  82. self.others_generator = _DefinitionGenerator(
  83. self.project, self.pyfunction, body=body)
  84. def _get_scope_range(self):
  85. scope = self.pyfunction.get_scope()
  86. lines = self.pymodule.lines
  87. logicals = self.pymodule.logical_lines
  88. start_line = scope.get_start()
  89. if self.pyfunction.decorators:
  90. decorators = self.pyfunction.decorators
  91. if hasattr(decorators[0], 'lineno'):
  92. start_line = decorators[0].lineno
  93. start_offset = lines.get_line_start(start_line)
  94. end_offset = min(lines.get_line_end(scope.end) + 1,
  95. len(self.pymodule.source_code))
  96. return (start_offset, end_offset)
  97. def get_changes(self, remove=True, only_current=False, resources=None,
  98. task_handle=taskhandle.NullTaskHandle()):
  99. """Get the changes this refactoring makes
  100. If `remove` is `False` the definition will not be removed. If
  101. `only_current` is `True`, the the current occurrence will be
  102. inlined, only.
  103. """
  104. changes = ChangeSet('Inline method <%s>' % self.name)
  105. if resources is None:
  106. resources = self.pycore.get_python_files()
  107. if only_current:
  108. resources = [self.original]
  109. if remove:
  110. resources.append(self.resource)
  111. job_set = task_handle.create_jobset('Collecting Changes',
  112. len(resources))
  113. for file in resources:
  114. job_set.started_job(file.path)
  115. if file == self.resource:
  116. changes.add_change(self._defining_file_changes(
  117. changes, remove=remove, only_current=only_current))
  118. else:
  119. aim = None
  120. if only_current and self.original == file:
  121. aim = self.offset
  122. handle = _InlineFunctionCallsForModuleHandle(
  123. self.pycore, file, self.others_generator, aim)
  124. result = move.ModuleSkipRenamer(
  125. self.occurrence_finder, file, handle).get_changed_module()
  126. if result is not None:
  127. result = _add_imports(self.pycore, result,
  128. file, self.imports)
  129. if remove:
  130. result = _remove_from(self.pycore, self.pyname,
  131. result, file)
  132. changes.add_change(ChangeContents(file, result))
  133. job_set.finished_job()
  134. return changes
  135. def _get_removed_range(self):
  136. scope = self.pyfunction.get_scope()
  137. lines = self.pymodule.lines
  138. logical = self.pymodule.logical_lines
  139. start_line = scope.get_start()
  140. start, end = self._get_scope_range()
  141. end_line = scope.get_end()
  142. for i in range(end_line + 1, lines.length()):
  143. if lines.get_line(i).strip() == '':
  144. end_line = i
  145. else:
  146. break
  147. end = min(lines.get_line_end(end_line) + 1,
  148. len(self.pymodule.source_code))
  149. return (start, end)
  150. def _defining_file_changes(self, changes, remove, only_current):
  151. start_offset, end_offset = self._get_removed_range()
  152. aim = None
  153. if only_current:
  154. if self.resource == self.original:
  155. aim = self.offset
  156. else:
  157. # we don't want to change any of them
  158. aim = len(self.resource.read()) + 100
  159. handle = _InlineFunctionCallsForModuleHandle(
  160. self.pycore, self.resource,
  161. self.normal_generator, aim_offset=aim)
  162. replacement = None
  163. if remove:
  164. replacement = self._get_method_replacement()
  165. result = move.ModuleSkipRenamer(
  166. self.occurrence_finder, self.resource, handle, start_offset,
  167. end_offset, replacement).get_changed_module()
  168. return ChangeContents(self.resource, result)
  169. def _get_method_replacement(self):
  170. if self._is_the_last_method_of_a_class():
  171. indents = sourceutils.get_indents(
  172. self.pymodule.lines, self.pyfunction.get_scope().get_start())
  173. return ' ' * indents + 'pass\n'
  174. return ''
  175. def _is_the_last_method_of_a_class(self):
  176. pyclass = self.pyfunction.parent
  177. if not isinstance(pyclass, pyobjects.PyClass):
  178. return False
  179. class_start, class_end = sourceutils.get_body_region(pyclass)
  180. source = self.pymodule.source_code
  181. lines = self.pymodule.lines
  182. func_start, func_end = self._get_scope_range()
  183. if source[class_start:func_start].strip() == '' and \
  184. source[func_end:class_end].strip() == '':
  185. return True
  186. return False
  187. def get_kind(self):
  188. return 'method'
  189. class InlineVariable(_Inliner):
  190. def __init__(self, *args, **kwds):
  191. super(InlineVariable, self).__init__(*args, **kwds)
  192. self.pymodule = self.pyname.get_definition_location()[0]
  193. self.resource = self.pymodule.get_resource()
  194. self._check_exceptional_conditions()
  195. self._init_imports()
  196. def _check_exceptional_conditions(self):
  197. if len(self.pyname.assignments) != 1:
  198. raise rope.base.exceptions.RefactoringError(
  199. 'Local variable should be assigned once for inlining.')
  200. def get_changes(self, remove=True, only_current=False, resources=None,
  201. task_handle=taskhandle.NullTaskHandle()):
  202. if resources is None:
  203. if rename._is_local(self.pyname):
  204. resources = [self.resource]
  205. else:
  206. resources = self.pycore.get_python_files()
  207. if only_current:
  208. resources = [self.original]
  209. if remove and self.original != self.resource:
  210. resources.append(self.resource)
  211. changes = ChangeSet('Inline variable <%s>' % self.name)
  212. jobset = task_handle.create_jobset('Calculating changes',
  213. len(resources))
  214. for resource in resources:
  215. jobset.started_job(resource.path)
  216. if resource == self.resource:
  217. source = self._change_main_module(remove, only_current)
  218. changes.add_change(ChangeContents(self.resource, source))
  219. else:
  220. result = self._change_module(resource, remove, only_current)
  221. if result is not None:
  222. result = _add_imports(self.pycore, result,
  223. resource, self.imports)
  224. changes.add_change(ChangeContents(resource, result))
  225. jobset.finished_job()
  226. return changes
  227. def _change_main_module(self, remove, only_current):
  228. region = None
  229. if only_current and self.original == self.resource:
  230. region = self.region
  231. return _inline_variable(self.pycore, self.pymodule, self.pyname,
  232. self.name, remove=remove, region=region)
  233. def _init_imports(self):
  234. vardef = _getvardef(self.pymodule, self.pyname)
  235. self.imported, self.imports = move.moving_code_with_imports(
  236. self.pycore, self.resource, vardef)
  237. def _change_module(self, resource, remove, only_current):
  238. filters = [occurrences.NoImportsFilter(),
  239. occurrences.PyNameFilter(self.pyname)]
  240. if only_current and resource == self.original:
  241. def check_aim(occurrence):
  242. start, end = occurrence.get_primary_range()
  243. if self.offset < start or end < self.offset:
  244. return False
  245. filters.insert(0, check_aim)
  246. finder = occurrences.Finder(self.pycore, self.name, filters=filters)
  247. changed = rename.rename_in_module(
  248. finder, self.imported, resource=resource, replace_primary=True)
  249. if changed and remove:
  250. changed = _remove_from(self.pycore, self.pyname, changed, resource)
  251. return changed
  252. def get_kind(self):
  253. return 'variable'
  254. class InlineParameter(_Inliner):
  255. def __init__(self, *args, **kwds):
  256. super(InlineParameter, self).__init__(*args, **kwds)
  257. resource, offset = self._function_location()
  258. index = self.pyname.index
  259. self.changers = [change_signature.ArgumentDefaultInliner(index)]
  260. self.signature = change_signature.ChangeSignature(self.project,
  261. resource, offset)
  262. def _function_location(self):
  263. pymodule, lineno = self.pyname.get_definition_location()
  264. resource = pymodule.get_resource()
  265. start = pymodule.lines.get_line_start(lineno)
  266. word_finder = worder.Worder(pymodule.source_code)
  267. offset = word_finder.find_function_offset(start)
  268. return resource, offset
  269. def get_changes(self, **kwds):
  270. """Get the changes needed by this refactoring
  271. See `rope.refactor.change_signature.ChangeSignature.get_changes()`
  272. for arguments.
  273. """
  274. return self.signature.get_changes(self.changers, **kwds)
  275. def get_kind(self):
  276. return 'parameter'
  277. def _join_lines(lines):
  278. definition_lines = []
  279. for unchanged_line in lines:
  280. line = unchanged_line.strip()
  281. if line.endswith('\\'):
  282. line = line[:-1].strip()
  283. definition_lines.append(line)
  284. joined = ' '.join(definition_lines)
  285. return joined
  286. class _DefinitionGenerator(object):
  287. unique_prefix = unique_prefix()
  288. def __init__(self, project, pyfunction, body=None):
  289. self.pycore = project.pycore
  290. self.pyfunction = pyfunction
  291. self.pymodule = pyfunction.get_module()
  292. self.resource = self.pymodule.get_resource()
  293. self.definition_info = self._get_definition_info()
  294. self.definition_params = self._get_definition_params()
  295. self._calculated_definitions = {}
  296. if body is not None:
  297. self.body = body
  298. else:
  299. self.body = sourceutils.get_body(self.pyfunction)
  300. def _get_definition_info(self):
  301. return rope.refactor.functionutils.DefinitionInfo.read(self.pyfunction)
  302. def _get_definition_params(self):
  303. definition_info = self.definition_info
  304. paramdict = dict([pair for pair in definition_info.args_with_defaults])
  305. if definition_info.args_arg is not None or \
  306. definition_info.keywords_arg is not None:
  307. raise rope.base.exceptions.RefactoringError(
  308. 'Cannot inline functions with list and keyword arguements.')
  309. if self.pyfunction.get_kind() == 'classmethod':
  310. paramdict[definition_info.args_with_defaults[0][0]] = \
  311. self.pyfunction.parent.get_name()
  312. return paramdict
  313. def get_function_name(self):
  314. return self.pyfunction.get_name()
  315. def get_definition(self, primary, pyname, call, host_vars=[],returns=False):
  316. # caching already calculated definitions
  317. return self._calculate_definition(primary, pyname, call,
  318. host_vars, returns)
  319. def _calculate_header(self, primary, pyname, call):
  320. # A header is created which initializes parameters
  321. # to the values passed to the function.
  322. call_info = rope.refactor.functionutils.CallInfo.read(
  323. primary, pyname, self.definition_info, call)
  324. paramdict = self.definition_params
  325. mapping = rope.refactor.functionutils.ArgumentMapping(
  326. self.definition_info, call_info)
  327. for param_name, value in mapping.param_dict.items():
  328. paramdict[param_name] = value
  329. header = ''
  330. to_be_inlined = []
  331. mod = self.pycore.get_string_module(self.body)
  332. all_names = mod.get_scope().get_names()
  333. assigned_names = [name for name in all_names if
  334. isinstance(all_names[name], rope.base.pynamesdef.AssignedName)]
  335. for name, value in paramdict.items():
  336. if name != value and value is not None:
  337. header += name + ' = ' + value.replace('\n', ' ') + '\n'
  338. to_be_inlined.append(name)
  339. return header, to_be_inlined
  340. def _calculate_definition(self, primary, pyname, call, host_vars, returns):
  341. header, to_be_inlined = self._calculate_header(primary, pyname, call)
  342. source = header + self.body
  343. mod = self.pycore.get_string_module(source)
  344. name_dict = mod.get_scope().get_names()
  345. all_names = [x for x in name_dict if
  346. not isinstance(name_dict[x], rope.base.builtins.BuiltinName)]
  347. # If there is a name conflict, all variable names
  348. # inside the inlined function are renamed
  349. if len(set(all_names).intersection(set(host_vars))) > 0:
  350. prefix = _DefinitionGenerator.unique_prefix.next()
  351. guest = self.pycore.get_string_module(source, self.resource)
  352. to_be_inlined = [prefix+item for item in to_be_inlined]
  353. for item in all_names:
  354. pyname = guest[item]
  355. occurrence_finder = occurrences.create_finder(
  356. self.pycore, item, pyname)
  357. source = rename.rename_in_module(occurrence_finder,
  358. prefix+item, pymodule=guest)
  359. guest = self.pycore.get_string_module(source, self.resource)
  360. #parameters not reassigned inside the functions are now inlined.
  361. for name in to_be_inlined:
  362. pymodule = self.pycore.get_string_module(source, self.resource)
  363. pyname = pymodule[name]
  364. source = _inline_variable(self.pycore, pymodule, pyname, name)
  365. return self._replace_returns_with(source, returns)
  366. def _replace_returns_with(self, source, returns):
  367. result = []
  368. returned = None
  369. last_changed = 0
  370. for match in _DefinitionGenerator._get_return_pattern().finditer(source):
  371. for key, value in match.groupdict().items():
  372. if value and key == 'return':
  373. result.append(source[last_changed:match.start('return')])
  374. if returns:
  375. self._check_nothing_after_return(source,
  376. match.end('return'))
  377. returned = _join_lines(
  378. source[match.end('return'): len(source)].splitlines())
  379. last_changed = len(source)
  380. else:
  381. current = match.end('return')
  382. while current < len(source) and source[current] in ' \t':
  383. current += 1
  384. last_changed = current
  385. if current == len(source) or source[current] == '\n':
  386. result.append('pass')
  387. result.append(source[last_changed:])
  388. return ''.join(result), returned
  389. def _check_nothing_after_return(self, source, offset):
  390. lines = codeanalyze.SourceLinesAdapter(source)
  391. lineno = lines.get_line_number(offset)
  392. logical_lines = codeanalyze.LogicalLineFinder(lines)
  393. lineno = logical_lines.logical_line_in(lineno)[1]
  394. if source[lines.get_line_end(lineno):len(source)].strip() != '':
  395. raise rope.base.exceptions.RefactoringError(
  396. 'Cannot inline functions with statements after return statement.')
  397. @classmethod
  398. def _get_return_pattern(cls):
  399. if not hasattr(cls, '_return_pattern'):
  400. def named_pattern(name, list_):
  401. return "(?P<%s>" % name + "|".join(list_) + ")"
  402. comment_pattern = named_pattern('comment', [r'#[^\n]*'])
  403. string_pattern = named_pattern('string',
  404. [codeanalyze.get_string_pattern()])
  405. return_pattern = r'\b(?P<return>return)\b'
  406. cls._return_pattern = re.compile(comment_pattern + "|" +
  407. string_pattern + "|" +
  408. return_pattern)
  409. return cls._return_pattern
  410. class _InlineFunctionCallsForModuleHandle(object):
  411. def __init__(self, pycore, resource,
  412. definition_generator, aim_offset=None):
  413. """Inlines occurrences
  414. If `aim` is not `None` only the occurrences that intersect
  415. `aim` offset will be inlined.
  416. """
  417. self.pycore = pycore
  418. self.generator = definition_generator
  419. self.resource = resource
  420. self.aim = aim_offset
  421. def occurred_inside_skip(self, change_collector, occurrence):
  422. if not occurrence.is_defined():
  423. raise rope.base.exceptions.RefactoringError(
  424. 'Cannot inline functions that reference themselves')
  425. def occurred_outside_skip(self, change_collector, occurrence):
  426. start, end = occurrence.get_primary_range()
  427. # we remove out of date imports later
  428. if occurrence.is_in_import_statement():
  429. return
  430. # the function is referenced outside an import statement
  431. if not occurrence.is_called():
  432. raise rope.base.exceptions.RefactoringError(
  433. 'Reference to inlining function other than function call'
  434. ' in <file: %s, offset: %d>' % (self.resource.path, start))
  435. if self.aim is not None and (self.aim < start or self.aim > end):
  436. return
  437. end_parens = self._find_end_parens(self.source, end - 1)
  438. lineno = self.lines.get_line_number(start)
  439. start_line, end_line = self.pymodule.logical_lines.\
  440. logical_line_in(lineno)
  441. line_start = self.lines.get_line_start(start_line)
  442. line_end = self.lines.get_line_end(end_line)
  443. returns = self.source[line_start:start].strip() != '' or \
  444. self.source[end_parens:line_end].strip() != ''
  445. indents = sourceutils.get_indents(self.lines, start_line)
  446. primary, pyname = occurrence.get_primary_and_pyname()
  447. host = self.pycore.resource_to_pyobject(self.resource)
  448. scope = host.scope.get_inner_scope_for_line(lineno)
  449. definition, returned = self.generator.get_definition(
  450. primary, pyname, self.source[start:end_parens], scope.get_names(), returns=returns)
  451. end = min(line_end + 1, len(self.source))
  452. change_collector.add_change(line_start, end,
  453. sourceutils.fix_indentation(definition, indents))
  454. if returns:
  455. name = returned
  456. if name is None:
  457. name = 'None'
  458. change_collector.add_change(
  459. line_end, end, self.source[line_start:start] + name +
  460. self.source[end_parens:end])
  461. def _find_end_parens(self, source, offset):
  462. finder = worder.Worder(source)
  463. return finder.get_word_parens_range(offset)[1]
  464. @property
  465. @utils.saveit
  466. def pymodule(self):
  467. return self.pycore.resource_to_pyobject(self.resource)
  468. @property
  469. @utils.saveit
  470. def source(self):
  471. if self.resource is not None:
  472. return self.resource.read()
  473. else:
  474. return self.pymodule.source_code
  475. @property
  476. @utils.saveit
  477. def lines(self):
  478. return self.pymodule.lines
  479. def _inline_variable(pycore, pymodule, pyname, name,
  480. remove=True, region=None):
  481. definition = _getvardef(pymodule, pyname)
  482. start, end = _assigned_lineno(pymodule, pyname)
  483. occurrence_finder = occurrences.create_finder(pycore, name, pyname)
  484. changed_source = rename.rename_in_module(
  485. occurrence_finder, definition, pymodule=pymodule,
  486. replace_primary=True, writes=False, region=region)
  487. if changed_source is None:
  488. changed_source = pymodule.source_code
  489. if remove:
  490. lines = codeanalyze.SourceLinesAdapter(changed_source)
  491. source = changed_source[:lines.get_line_start(start)] + \
  492. changed_source[lines.get_line_end(end) + 1:]
  493. else:
  494. source = changed_source
  495. return source
  496. def _getvardef(pymodule, pyname):
  497. assignment = pyname.assignments[0]
  498. lines = pymodule.lines
  499. start, end = _assigned_lineno(pymodule, pyname)
  500. definition_with_assignment = _join_lines(
  501. [lines.get_line(n) for n in range(start, end + 1)])
  502. if assignment.levels:
  503. raise rope.base.exceptions.RefactoringError(
  504. 'Cannot inline tuple assignments.')
  505. definition = definition_with_assignment[definition_with_assignment.\
  506. index('=') + 1:].strip()
  507. return definition
  508. def _assigned_lineno(pymodule, pyname):
  509. definition_line = pyname.assignments[0].ast_node.lineno
  510. return pymodule.logical_lines.logical_line_in(definition_line)
  511. def _add_imports(pycore, source, resource, imports):
  512. if not imports:
  513. return source
  514. pymodule = pycore.get_string_module(source, resource)
  515. module_import = importutils.get_module_imports(pycore, pymodule)
  516. for import_info in imports:
  517. module_import.add_import(import_info)
  518. source = module_import.get_changed_source()
  519. pymodule = pycore.get_string_module(source, resource)
  520. import_tools = importutils.ImportTools(pycore)
  521. return import_tools.organize_imports(pymodule, unused=False, sort=False)
  522. def _get_pyname(pycore, resource, offset):
  523. pymodule = pycore.resource_to_pyobject(resource)
  524. pyname = evaluate.eval_location(pymodule, offset)
  525. if isinstance(pyname, pynames.ImportedName):
  526. pyname = pyname._get_imported_pyname()
  527. return pyname
  528. def _remove_from(pycore, pyname, source, resource):
  529. pymodule = pycore.get_string_module(source, resource)
  530. module_import = importutils.get_module_imports(pycore, pymodule)
  531. module_import.remove_pyname(pyname)
  532. return module_import.get_changed_source()